"Bill Tutt" <rassilon@lyra.org> writes:
> For a long time now libsvn_fs/tree.c could not correctly resolve out the
> laziness inherent in our O(1) copy model. That is no longer true. This
> patch allows mod_dav_svn to report the correct "NodeRevision first
> visible on this path at revision number X". This is accomplished by the
> following changes:
> * Record non-root bubble up changes in the changes table.
> * svn_fs_node_created_rev now reports the "first visible on this path"
> created revision number.
> * svn_fs_dir_entries() now includes the new created_rev in the
> svn_fs_dirent_t structure.
> * svn_fs_revisions_changed() now stops immediately if cross_copy_history
> is false.
Hmm... a couple of initial formatting annoyances with this patch. You
are using "foo()" instead of "foo ()", which is inconsistent with the
rest of tree.c. Also, your indentation differs from the rest of the
code in places.
Another concern was mentioned by Ben, and I think I echo the same
concern. Namely, are the additional `changes' table items for
bubble-up directories a necessity or an optimization? If they are an
optimization, I'd like to discuss whether that optimization outweighs
the costs: a one-time dump/load cycle requirement, but then a
tremendous bloat in the size of the changes table itself.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 25 18:43:46 2002