[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3894 - trunk/subversion/libsvn_subr

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2002-11-25 18:24:49 CET

On Mon, 2002-11-25 at 11:37, cmpilato@collab.net wrote:
> kfogel@tigris.org writes:
>
> > * subversion/libsvn_subr/error.c
> > (svn_error_compose): Revert revision 3893, and destroy the correct
> > pool instead.
>
> Oops... sorry 'bout that.

My fault, really. I cleverly stashed new_err's pool so that I wouldn't
need to indirect through an invalid pointer to get it later, and then
promptly indirected through an invalid pointer instead of using the
stashed pool. Sigh.

(Clearly our test suite doesn't test svn_error_compose. But that's
probably okay, since I think it should go away anyway.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 25 18:25:57 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.