Re: [PATCH]: SIGSEGV in repos to repos copy

David Kimdon <dwhedon@debian.org> writes:

> * subversion/libsvn_client/copy.c: (repos_to_repos_copy) When doing
> a repos to repos copy if source is a subdir of destination we need
> to open an RA session of the parent of source, otherwise we segfault
> when trying to determine the repos destination path.

While your patch does fix the mentioned bug, it's not quite the
preferred fix. By rooting the editor at the parent of the source and
destination copy URLs, we add another pair of network turnarounds. In
this case, it's unnecessary to do this because we would always be
operating on grandchildren of that root URL.

The SEGFAULTs you saw come merely as a result of using svn_path_join
with a NULL path (dst_rel in the code). I'm testing a fix of this
NULL usage now; I'll commit up soon.

(Man, I feel like I'm beating up on your patches lately, David. I
 swear I'm not trying to!)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 25 15:34:39 2002