"Glenn A. Thompson" <gthompson@cdr.net> writes:
> OK. I can take a wack at it. But the next couple weeks I really have
> to focus on my other work.
> So I may just keep updating every night. I have been doing it for
> weeks. In other words just keep it working locally.
> Then when I get my time back, I'd do as you suggest. Is that OK?
Sure!
> I understand. Which ones do you consider interesting in a general
> sense? Basically, the whole patch revolves around adding indirection.
Well, yeah, really you're right -- the entire patch is a no-op in
terms of functional changes. So once we get all those applied, there
won't be any patch left, and the branch will really be for the sql
backend :-).
> OK. I may need some help identifying what is an appropriate first
> patch. Would the trail vtable combined with the
> (baseline_db_access_funcs_t now called svn_fs__bl_db_access_funcs_t)
> be too huge? It would at least limit all changes to libsvn_fs and
> below. Actually, no it won't. The test stuff would still have to
> change some. Once I rename the bdb functions, it would be nice to go
> ahead and add the indirection as I will have to change those lines
> anyway.
That sounds good, yeah. Obviously there's a limit on how much one can
break up some of these changes.
> Certainly the api vtable can come later That one is a bit
> scary hun? But I really do need it long term. Some of the structures
> I moved into fs-base-impl.h I may be able to move in a second round.
> Sorry guys. I guess I'm a little monolithic in my thinking:-) Let me
> simmer over the weekend.
Sure.
> Mike you poor sick puppy:-) Did you get the short straw?
Nah, he volunteered, can you believe it?
> It's alright Karl. I kinda expected this. After all, I've already
> pulled some changes out. As I tried to explain to Ben and Mike at
> dinner. My struggle was how to show where I'm headed on this stuff.
> My initial web pages did a poor job. So, I just rolled and rolled and
> rolled thinking the code would do it. I'm much better at verbal
> communication than written.
No problem at all. It's very clear where you're headed, and the log
message is quite readable too. Just big :-).
> I'm sorry if I diverted you guys from other work. Assuming I can meet
> svn standards, I will help out on the milestones down the road to help
> make up for my coming to the party so late.
Oh gosh, I fear I've made it sound as though there's some exclusive
membership requirement for this club or something, sorry. We're not
trying to set up barriers and gates here; the only reason I'm
recommending this course is because I think it's the fastest way to
get these changes incorporated safely.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 22 19:34:34 2002