[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: hot-backup.py patch

From: Peter Davis <peter_at_pdavis.cx>
Date: 2002-11-20 22:40:28 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[bringing back on the dev list]

On Wednesday 20 November 2002 13:17, you wrote:
> >On Wednesday 20 November 2002 08:48, Michael Price wrote:
> > > +if os.path.isdir(backup_subdir):
> > > + print "Backup of revision %s already exists." % backup_subdir,
> > > + sys.exit(0)
> >
> > Instead of only checking for a directory, why not check that the target
> > exists at all? I wouldn't want to overwrite any files, either.
>
> Doesn't really matter to me. The copytree() function won't overwrite
> anything regardless of what it is.

Oh, ok, I guess it doesn't /really/ matter then.

> I just wanted the script to exit
> gracefully rather than dump a backtrace because of an unhandled exception.

> As a side note -- are you receiving dev@subversion.tigris.org emails? I
> haven't received any since the 18th which is also the last one shown on
> the web page.

Yes, I've probably received 100 emails in the past two days. That's weird:
the archive really does stop on the 18th. Anyone know what's up?

- --
Peter Davis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD4DBQE93AFMhDAgUT1yirARAqT9AJ4pEZlCGSBLHlSNHORi0ZTfQFwfHwCYrJpD
Bc6HbgEmt2LerC87/D5KHQ==
=neM+
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 20 22:41:12 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.