Karl Fogel <kfogel@newton.ch.collab.net> writes:
> I don't know if it's really 100 other types, but maintaining a
> list in svn_mime_type_is_binary() doesn't strike me as madness.
> Subversion has to maintain it somewhere, after all.
Hard-coding configuration data (yes, that's what it is) in your
code is generally considered a bad idea. You've already gotten a
tiny taste of one of the reasons. Let's say it isn't 100 other
types, let's say it's only 5. Fine, but as you have
demonstrated, you do not know them all. When i go to configure
svn for my environment but my lusers need the media type
application/x-we-suck to be treated as text, i have to modify the
code instead of a configuration file. Hey, thinking of the
application/x-we-suck type, let's say it's a type used for some
internal type of file that the world never sees. svn certainly
won't know about that one.
As for the number i chose, 100, it isn't as far off as it seens.
The geniuses in the XML world have decided on types like
application/xml, application/html+xml and image/svg+xml rather
than text/xml (or, if you simply *must* have something more
specific, text/svg+xml). If we don't have 100 such busted types
today, we will in a few years.
(Yes, i know we have text/xml also, but application/xml is
preferred over it and a more specific type is even more
preferred.)
--
Eric Gillespie <*> epg@pretzelnet.org
Build a fire for a man, and he'll be warm for a day. Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 18 19:00:28 2002