Re: svn_error_compose and (potential) memory leaks

Greg Hudson <ghudson@MIT.EDU> writes:

> In commit.c and copy.c, this means not reporting errors which might
> occur in svn_wc_adm_close() and remove_tmpfiles() when there is an error
> bumping revisions or committing. (I'm not sure why we're not just
> relying on pool cleanup handlers, really; then we could just use SVN_ERR
> instead of going through all these hoops.)

Probably because the code was written before there was much (or any?)
use of pool cleanup handlers in Subversion. As I recall, when I added
a pool cleanup handler to the wc diff code there was only one other
handler in the Subversion code.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org