[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] UTF-8 bugfixes

From: Marcus Comstedt <marcus_at_mc.pp.se>
Date: 2002-11-13 18:10:42 CET

Hello, I'm back... :-)

I found a bug in io.c in the current Subversion: svn_io_copy_file()
incorrectly assumes that you can pass a natively encoded path to
svn_io_open_unique_file() and in return get a natively encoded path
back. This is of course not the case since svn_io_open_unique_file()
actually has to open the file, so the path parameter has to be of a
known charset (i.e. UTF-8, since this is a public function).

Attached is a patch which fixes the problem. (B.t.w.: the problem
visible to the user was that you could not e.g. do a checkout to a
destination directory containing non-ASCII characters.)

I've also included my libsvn_repos/repos.c patch again (now against
rev 3735), since it still hasn't been applied even though it's been
months since I submitted it. So in case you lost it or something...
(This patch fixes the bug that svnadmin can't create local
 repositories with non-ASCII characters in their pathnames.)

Log messages for the two patches:

---------------

* subversion/libsvn_subr/io.c
  (svn_io_copy_file): Corrected some improper use of native vs UTF-8
  pathnames.

---------------

* subversion/libsvn_repos/repos.c
  (create_locks, create_hooks, svn_repos_create): Use
  svn_io_dir_make() instead of apr_dir_make(), so that the paths are
  properly translated from UTF-8.

---------------

  // Marcus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Nov 13 18:12:08 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.