Karl Fogel <kfogel@newton.ch.collab.net> writes:
> Branko Čibej <brane@xbc.nu> writes:
> > Ah, but the whole point is that it's _not_ [eminently
> > solveable]. Taking file associations into account, there could be
> > literally hundreds of extensions to check. Trying that doesn't make
> > sense, when it's so easy to make the whole process
> > platform-independent. What's the difference between editing a script,
> > and editing a config file?
>
> Hundreds???
>
> I didn't realize it was that bad.
>
> Okay, can you put your hook proposal in an issue? It doesn't look so
> much like overkill anymore :-).
Wait, I'm sorry to revisit this, please bear with me. I wasn't
thinking straight above.
It may be that there are hundreds of possible extensions, but that
doesn't mean we need to try them all. We just need to document which
ones we try, namely, ".bat" and ".exe" (maybe ".com" too?). The other
extensions don't matter, because *anyone* can write a .bat file.
As far as I know, Win32 is the only platform that has an extension
requirement. Everywhere else, you can run a file of any name, right?
So in the Win32 case, we just try appending a few extensions. This
can happen in Subversion code quite easily.
Recall that we *had* the whole config-file vs plain program discussion
ages ago. In fact, the original hook design (from me!) used a config
file, and others pointed that it was unnecessary. The reason I'm so
resistant to it now is that it adds an extra interface layer without
adding one whit of extra functionality. We're making more work for
ourselves, in terms of code and especially in terms of
explaining/documenting the interface to users.
So, are you sure this isn't "eminently solveable" without a config
file? It looks like it is to me.
Note that I'm not arguing against repository config files in general.
I just don't see how they'd help our hook system.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 13 16:53:13 2002