[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Changing the way the server looks for hooks

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-11-12 21:35:17 CET

Branko Čibej <brane@xbc.nu> writes:
> Before I sign off for today, I'd like to share this in case I forget...
>
> Currently our repository hooks system is very Unixy, and in fact only
> works in Unix. That's because libsvn_repos tries to run specific files
> in the hooks/ directory, and on Windows, for example, those files don't
> have the right extension to be "executable".
>
> [...]
>
> and so on, you get the idea.
>
> The hooks would be run in the order they're defined in the [glohal]
> section, and cwd of hook programs would always be the repo/hooks
> directory (or maybe that could be configurable, too). For backward
> compatibility, we'd still try to run the files that are used now, but I
> propose we deprecate that behaviour and remove it before Beta.

Urk. It seems like a lot of added complexity, for administrators as
well as Subversion developers.

The comments in our hook templates indicate that we (well, I) always
expected the hooks to work under Windows, with ".exe" or ".bat"
appended. Maybe I was assuming that the APR subprocess invocation
routines would try adding ".exe" and/or ".bat" under Windows?

Anyway, if APR doesn't do that, that's okay. We can either add some
option to APR so it tries that, or put a little Win32-specific block
into our hook-running code (this would be a justifiable instance of
platform-specific code, imho, same as with the config stuff).

How does that sound?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 12 22:09:20 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.