Re: svn commit: rev 3757 - trunk/subversion/libsvn_wc

Philip Martin <philip@codematters.co.uk> writes:
> > - return svn_error_createf (SVN_ERR_WC_LOCKED, 0, NULL,
> > - "working copy locked: %s", adm_access->path);
> > + err = svn_error_create (SVN_ERR_WC_LOCKED, 0, NULL,
> > + "run 'svn cleanup' to remove locks;"
> > + " type 'svn help cleanup' for details");
>
> I don't think the library should refer to the command line client, as
> the advice is not appropriate for any other client. The client itself
> should trap SVN_ERR_WC_LOCKED and add an appropriate message.

+1... And if the client checks function Foo() for this error return,
then Foo's documentation (and the docs for the chain below it, down to
the original error source) need to say so.

Sigh, nothing is ever small :-).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 12 18:24:24 2002