Re: svn status: does not notice changed file if timestamp of "new" file is older

solo turn <soloturn99@yahoo.com> writes:

> maybe the date comparison logic is screwed? which file is it in?

I told you the name of the routine already: svn_wc_text_modified_p().
Take a read of that whole section in libsvn_wc/questions.c.

> i think you can only use date comparison for speeding up the
> comparison, but never judge the contents of a file by "this file has
> newer date than the other".

You can make one simple judgement: that equal timestamps implies no
change. If the timestamps are unequal, you can't assume anything.

The basic logic is:

   if (entry timestamp == working-file timestamp)
       return NOT_MODIFIED;
   else if (text-base filesize != working filesize)
       return MODIFIED;
   else /* brute force */
       do a byte-for-byte comparison

But unless you can give us a recipe for a bug, I don't think we can
track this problem down. Do you have an exact recipe?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 12 14:38:25 2002