Daniel Rall wrote:
>blair@tigris.org writes:
>
>
>
>>Author: blair
>>Date: 2002-11-11 15:53:43 -0600 (Mon, 11 Nov 2002)
>>New Revision: 3734
>>
>>Modified:
>> trunk/subversion/tests/clients/cmdline/prop_tests.py
>>Log:
>>* subversion/tests/clients/cmdline/prop_tests.py
>> (copy_should_preserve_executable_bits): New regression test for
>> issue #982. Right now this test is set to XFail and only run on
>> POSIX systems.
>>
>>
>>Modified: trunk/subversion/tests/clients/cmdline/prop_tests.py
>>==============================================================================
>>--- trunk/subversion/tests/clients/cmdline/prop_tests.py (original)
>>+++ trunk/subversion/tests/clients/cmdline/prop_tests.py Mon Nov 11 15:53:44 2002
>>@@ -17,7 +17,7 @@
>> ######################################################################
>>
>> # General modules
>>-import string, sys, re, os.path
>>+import stat, string, sys, re, os.path
>>
>>
>
>Minor detail regarding os.path in the Subversion Python code; path is
>a variable of the os module (of type "posixpath"),
>
Oh, is it?
>>> import os.path
>>> os.path
<module 'ntpath' from 'c:\Program Files\Python\lib\ntpath.pyc'>
:-)
>thus importing
>os.path actually imports the os module. We might as well stop fooling
>ourselves and import os explicitly (rather than importing os.path).
>:-)
>
I think it's good style to import os.path and not os, it all we're using
is stuff from the os.path module.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 11 23:50:10 2002