Karl Fogel <kfogel@newton.ch.collab.net> writes:
> Philip Martin <philip@codematters.co.uk> writes:
> > Just because the client gets notify callbacks in the wrong order
> > doesn't mean it has to display them in that order. The command line
> > client can accumulate the information supplied by the callbacks, and
> > then sort it and print it when the svn_client_statuses call returns.
> > A GUI client can decide to update the GUI with the information as it
> > receives it, or to update some progress indicator and do post
> > svn_client_statuses processing like the command line client. Give the
> > information to the application and let the application make the
> > decision.
>
> In other words, the `statushash' data structure becomes specific to
> the command-line (or whatever) client code, rather than being part of
> svn_client_status()'s interface, and svn_client_status() uses just the
> notification callbacks to return information?
Hmmm, that's not how I interpreted it. I don't think we need to go so
far as eradicating the returned-hash from svn_client_status(). I mean
yes, we *could* do that, but then it means that the notification
callback *must* return a status structure. That's pretty yucky.
We've been trying to keep our notification callback very simple.
Instead, a client should have many options:
1. just use the full hash when it comes back, ignore notification.
2. just use the notification callback, ignore the full hash.
(as I mentioned earlier, it can still retrieve status-structures
if the statushash lives within the notify-baton.)
3. Do some combination of both: use notification to make a cursor
spin, and then sort the final hash for display.
I think this is the most flexible.
But in order to enable option #2, it means that I'll still have to
reverse the order of the passes -- do network first, then local. Not
a huge deal.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 11 19:41:44 2002