Re: svnlook diff fails on binary files:

Blair Zajac <blair@orcaware.com> writes:

> Just to be beat this into the ground, when diff returns 2, svnlook
> quits immediately and doesn't generate the entire diff for the
> revision, hence our commit email will be lacking info.

I don't understand. Every time I've ever run diff on a binary file,
it either prints nothing (no diff) or "Binary files foo and bar
differ". Is this not true for you?

Oh, I see.

   % cd /usr/share/pixmaps
   % diff tycoon.png ximian_button_pill.png
   Binary files tycoon.png and ximian_button_pill.png differ
   % echo $?
   2

So, the problem isn't so much that diff is run on binary files, it's
that we aren't discerning the meaning of the 2 error code in this
case. And since error code 2 is a really generic error code for diff,
the best thing to do is just to not diff binary files. Am I on track?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 9 07:32:53 2002