Re: [PATCH] Remove use of global_pool to apr_xlate

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> There might be some implications about opening multiple iconv streams
> per process or thread, but I don't see anything that leads me to
> believe that iconv is inherently thread-unsafe.

I was looking at apr_xlate_t and it does look thread safe.

> Philip, can you please try this patch out with your stress test? --
> justin

Is it me, or did your mailer mangle this patch?

> * subversion/libsvn_subr/utf.c (get_ntou_xlate_handle,
> get_uton_xlate_handle): No longer walk up the tree looking for
> global_pool, but rather just use the passed-in pool.

I think you have fixed it. I've just run the test to get 600
revisions comitted, hundreds more commit attempts, and 18 minutes of
CPU spread over 6 httpd threads. Before applying the patch the test
would normally fail before 50 revisions.

Do you know what the problem was? Perhaps it was that the
apr_pool_userdata_get in one thread is affected by another thread
doing apr_pool_userdata_set? I can see that would cause problems if
the set causes the hash table to reallocate.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org