Re: svn commit: rev 3662 - trunk/subversion/mod_dav_svn trunk/subversion/tests/clients/cmdline/svntest

Quoting Greg Stein <gstein@lyra.org>:

> On Thu, Nov 07, 2002 at 08:48:52PM +0100, Branko Cibej wrote:
> >...
> > How about this patch instead?
>
> +1, but for a tweak below:
>
> >...
> > +++ subversion/libsvn_ra_dav/log.c (working copy)
> >...
> > + const char *this_path =
> > + apr_xml_quote_string(ras->pool, ((const char **)paths->elts)[i], 1);
> > + svn_stringbuf_appendcstr(request_body, "<S:path>");
> > + svn_stringbuf_appendcstr(request_body, this_path);
> > + svn_stringbuf_appendcstr(request_body, "</S:path>");
>
> Since the value does not go into an attribute, there is no reason to
> escape the quotes. Thus, pass 0 for the third arg to quote_string().

Ouch, of course. Will commit this tonight if nobody beats me to it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 8 09:25:01 2002