[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Need help with this DAV stuff

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-11-06 21:43:49 CET

Greg Stein wrote:

>On Wed, Nov 06, 2002 at 09:03:58PM +0100, Branko Cibej wrote:
>
>
>>...
>>If apr_xml_quote_string doesn't always allocate new space for its
>>result, then that's either a bug in that function, _or_ it must
>>guarantee that the returned pointer will be the same as the one passed
>>in,
>>
>>
>
>The latter:
>
> /* nothing to do? */
> if (extra == 0)
> return s;
>
>(the doc ought to be updated for that in the header...)
>
Yup, I saw the same thing in the code just now. Maybe I'll just update
the docstring.

>>in which case we can check that and pstrdup only when necessary. Right?
>>
>>
>
>That would be much better than strdup'ing all the time.
>
>
I thought so, too. Besides, in some cases we probably know that the
lifetime of the original string is already correct.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 6 21:44:51 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.