Re: Need help with this DAV stuff

Peter Davis <peter@pdavis.cx> writes:

> > I think mod_dav_svn/update.c:upd_change_xxx_prop needs to apr_pstrdup
> > name. It calls apr_xml_quote_string but that doesn't reallocate if
> > there is nothing to quote.
>
> Not that I know shack jit about anything, but would this problem affect
> everywhere else that apr_xml_quote_string is used as well?

No, not everywhere. It's only a problem if the memory supplied as
input to apr_xml_quote_string gets reused before the output from
apr_xml_quote_string is used. In this case the output was stored, and
I suspect the pool from which the input was allocated got cleared
before the stored value was used.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org