Re: svn commit: rev 3643 - trunk/subversion/include trunk/subversion/libsvn_repos

On Mon, Nov 04, 2002 at 12:37:45PM -0600, Karl Fogel wrote:
> kfogel@tigris.org writes:
> > Log:
> > Resolve issue #966: empty input caused 'svnadmin load' to segfault.
> >
> > * subversion/include/svn_error_codes.h
> > (SVN_ERR_BAD_INPUT): New error code.
> >
> > * subversion/libsvn_repos/load.c
> > (svn_repos_parse_dumpstream): Check that the first call to
> > svn_stream_readline got some data.
>
> I also tried to write a regression test for this, but got stumped on
> the question of how to portably feed empty input to 'svnadmin load' on
> stdin, in Python. (Is creating empty file even a necessary part of
> this?) Anyone know an answer off the top of their head? I could

Yup. When you start the subprocess (via a popen varient), you get back a
pipe that is connected to the child process' stdin. Just close the end in
the parent. The child process sees that as EOF.

I'm not sure about the proces invocation stuff in the test suite. One of the
things that I've wanted to get to, but just haven't. You'll need to poke
around for it.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org