[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Changing mmn in Apache

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2002-11-04 18:28:38 CET

On Mon, Nov 04, 2002 at 11:40:03AM -0500, Tim Moloney wrote:
> Joe Orton wrote:
>
> >If you're building 2.0.43, you should change the "%define mmn xxxx" at
> >the top of httpd.spec to use the new MMN number, so that this
> >incompatiblity is reflected in the package dependencies. Any Apache 2.0
> >module packages designed to work with the Red Hat Linux 8.0 httpd
> >package should have a line like:
> >
> >Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn)
> >
> >so that they pick up a dependency on the module ABI version.
>
> Yes, you're right. Doing this would catch the incompatibility
> at installation time rather than at runtime. Since Greg Stein
> has convinced me that my short-cut is a bad idea, I will
> definitely do this and rebuild the RPMs for the modules I need.
> Thanks for the reminder.

Great. I've added a check to our %pre which checks that %mmn matches the
value from the actual sources, to avoid this kind of thing in the
future:

# Safety check: prevent build if defined MMN does not equal upstream
vmmn=`echo MODULE_MAGIC_NUMBER_MAJOR | cpp -include \`pwd\`/include/ap_mmn.h | grep -v '#'`
if test "x${vmmn}" != "x%{mmn}"; then
   : Error: Upstream MMN is now ${vmmn}, packaged MMN is %{mmn}.
   : Update the mmn macro and rebuild.
   exit 1
fi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 4 18:32:22 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.