[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3598 - trunk/subversion/libsvn_fs

From: <cmpilato_at_collab.net>
Date: 2002-11-01 14:30:15 CET

Greg Stein <gstein@lyra.org> writes:

> > (The editor interface sometimes doesn't pass in a
> > pool because it knows the stashed pool will only be usd once; I think
> > that was a mistake, just in terms of consistency, but it has no
> > practical problems.)
>
> In retrospect, yah. It was a definite improvement to add the pool
> parameters, but I should have added the pool to more of the calls. I seem
> to recall a situation where it actually would have been good to pass a pool
> to the apply_textdelta or close_foo or whatever it was; I can't
> remember/imagine why that was the case, which is why the pool *isn't*
> passed in the first place, but I think there was one.

Well, we can certainly add the pool parameter to the editor
interfaces. I mean, let's do it now, before 1.0. Unlike the previous
editor conversion, this one doesn't changed any semantics. It's a
trivial change -- in fact, I'll start on it on the train in to the
city today.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 1 14:33:08 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.