Re: svn commit: rev 3458 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/svnlook trunk/subversion/tests

On Wed, Oct 23, 2002 at 02:34:30AM -0500, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/svnlook/main.c Wed Oct 23 02:34:30 2002
>...
> @@ -645,15 +641,13 @@
>
> /* Recursively handle the node's children. */
> subpool = svn_pool_create (pool);
> - full_path = svn_stringbuf_dup (path, subpool);
> - svn_path_add_component_nts (full_path, node->name);
> - SVN_ERR (print_ids_tree (node, root, full_path, indentation + 1,
> - subpool));
> + full_path = svn_path_join (path, node->name, subpool);
> + SVN_ERR (print_ids_tree (node, root, full_path, indentation + 1, subpool));
> while (node->sibling)
> {
> + svn_pool_clear (subpool);
> node = node->sibling;
> - svn_stringbuf_set (full_path, path->data);
> - svn_path_add_component_nts (full_path, node->name);
> + full_path = svn_path_join (path, node->name, pool);

Funny place for the clear; we normally put that at the end.

The full_path construction doesn't use the subpool.

>...
> @@ -811,8 +805,7 @@
> SVN_ERR (generate_delta_tree (&tree, c->repos, root, base_rev_id,
> TRUE, pool));
> if (tree)
> - SVN_ERR (print_dirs_changed_tree (tree, svn_stringbuf_create ("", pool),
> - pool));
> + SVN_ERR (print_dirs_changed_tree (tree, "", pool));

Damn, that's beautiful. I always hated seeing crap like that. And when I had
to write the same in ra_dav? Grr... :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org