Re: svn commit: rev 3429 - trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

On Mon, Oct 21, 2002 at 01:12:10PM -0500, kfogel@tigris.org wrote:
>...
> * subversion/libsvn_client/add.c
> (svn_client_add): Don't wrap the error; the original error message
> contains the path, without which the warning is quite obscure.
> Having the original error be a child of the new error didn't help,
> because the error eventually reaches svn_handle_warning, not
> svn_handle_error. Also, remove unnecessary parens and reformat to
> 80 columns.
>...
> - if ((kind == svn_node_dir) && (recursive))
> - err = add_dir_recursive (path, adm_access, notify_func, notify_baton, pool);
> + if ((kind == svn_node_dir) && recursive)

Heh. You didn't remove all the unnecessary parens :-)

/me continues to wonder why people think that == doesn't bind tighter than
&& or || ... Maybe too many LISPers and they're trying to apply their
bad^H^H^HLISP habits to SVN...

:-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org