Re: [PATCH] [Issue 870] import should set svn:executable automatically

Brian Denny <brian@briandenny.net> writes:

> > According to the APR documentation all this user/group stuff is only
> > available if APR_HAS_USER is defined, so we probably need
> >
> > #ifdef APR_HAS_USER
> > #endif
> >
> > around this code.
>
> sounds good. if APR_HAS_USER is not defined, then what is correct
> behavior?

I don't know, not setting svn:executable perhaps?

> btw, it appears that "apr_current_userid" is used in two other places
> in the subversion code, in both cases without checking for APR_HAS_USER
> as far as i can see:
> libsvn_client/auth.c:96
> libsvn_subr/config_file.c:318

That indicates that you could, justifiably, ignore the APR_HAS_USER
issue :) Or send a patch. No, I don't know what the code should do if
APR_HAS_USER is not set. Until someone builds on an affected platform
I would ignore the problem, as it may never arise.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org