Re: [PATCH] [Issue 870] import should set svn:executable automatically

On 25 Sep 2002, Philip Martin wrote:

> Nice patch, can we have a log message please :)

sure. :)

> i.e. if there is group execute, but not user execute and I am both
> user and group then I cannot execute.

oh! i didn't realize that.
you are correct. i'll change the logic accordingly.

> According to the APR documentation all this user/group stuff is only
> available if APR_HAS_USER is defined, so we probably need
>
> #ifdef APR_HAS_USER
> #endif
>
> around this code.

sounds good. if APR_HAS_USER is not defined, then what is correct
behavior?

btw, it appears that "apr_current_userid" is used in two other places
in the subversion code, in both cases without checking for APR_HAS_USER
as far as i can see:
  libsvn_client/auth.c:96
  libsvn_subr/config_file.c:318

> The value of the executable property is not relevant, only it's
> presence or absence matters. I think "" would be better here, since
> by setting it "true" we are encouraging the user to try setting it
> "false".

will do.

thanks for the feedback,
:brian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 25 20:11:39 2002