Re: [PATCH] (alternate fix for issue 900)

Branko ÄŒibej <brane@xbc.nu> writes:

> mark benedetto king wrote:
>
> >Bill Tutt convinced me that adding svn_error_cause() was not a good
> >idea (people might be tempted to use it). I've inlined it instead.
> >As an added benefit, the scope of the patch is reduced.
> >
>
> This is the wrong approach, regardless. We're wrapping the error chain
> already, and svn_handle_error will print out the whole chain. So the
> original "cause" should be apparent. Why isn't it?

svn_repos_open doesn't distinguish between a missing format file and a
format file it cannot read, both cause the function to return
SVN_ERR_REPOS_UNSUPPORTED_VERSION. svn_ra_local__split_URL wants to
distinguish between these two cases. It may be better to change
svn_repos_open, document the behaviour, and then use that in
svn_ra_local__split_URL.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org