Re: Source of memory leak in mod_proxy?

On Wed, Sep 04, 2002 at 02:53:53PM -0700, Justin Erenkrantz wrote:
> On Wed, Sep 04, 2002 at 05:48:13PM -0400, Bill Stoddard wrote:
> > I just got a bug report that that the rewrite of ap_get_client_block() has
> > introduced a memory leak. Problem is observed when putting a large file to
> > the server via webdav. Replacing the 2.0.40 implementation with the 2.0.39
> > implementation (on a 2.0.40 code base) eliminates the problem. I do not have
> > time to investigate this now. I can take a look tomorrow or perhaps this
> > evening if no one wants to pick it up.

[ Bill refers to revision 1.437 of http_protocol.c ]

> Ah, I bet it should destroy the brigade after flattening. -- justin

Yup. On the error exits, too.

You know... I bet this will also solve the 'svn import' problem that we've
been seeing lately. In that case, the server memory just skyrockets,
proportional to the amount of data imported. This would do it.

[ see http://subversion.tigris.org/issues/show_bug.cgi?id=860 ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org