[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

tossing stringbuf functions (was: [PATCH] But with trailing slashes...)

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-09-04 23:20:32 CEST

On Wed, Sep 04, 2002 at 09:38:36PM +0100, Philip Martin wrote:
>...
> pass NULL. What about the (unused) stringbuf version of the function
> 'void svn_path_canonicalize (svn_stringbuf_t *)' would that accept
> NULL as well?

Unused? Well, then (IMO) it should just go away.

I see no reason to apply canonicalization to stringbufs. The stringbuf type
should be reserved only to "uses" of appending lots of bytes to build up a
final string. We should not encourage other uses (via the presence of
functions which operate on stringbufs).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 4 23:21:39 2002

This is an archived mail posted to the Subversion Dev mailing list.