Re: [PATCH] But with trailing slashes in SVNPath command in httpd.conf

Philip Martin wrote:

>Branko ÄŒibej <brane@xbc.nu> writes:
>
>
>
>>>NULL is not a canonical path, lots of the Subversion functions will
>>>dump core on a NULL path. I suppose it could return the empty path
>>>("") but I don't think that's a good thing to do.
>>>
>>>
>>>
>>If "" is the current directory these days, then canonicalizing NULL to
>>"" would definitely be wrong. :-)
>>
>>
>
>Agreed.
>
>
>
>>>I am happy saying that NULL is an error.
>>>
>>>
>>>
>>Sure. The question is whether svn_path_canonicalize sould abort on
>>NULL, or pass it through and let some other code abort instead.
>>
>>
>
>It would require special case code in svn_path_canonicalize_nts
>instead of at the places that call it, and not all the callers need it
>as some cannot have a NULL argument. My first instinct is to say the
>current code is correct, it is the responsibilty of the caller not to
>pass NULL.
>
Heh, right, good point.

> What about the (unused) stringbuf version of the function
>'void svn_path_canonicalize (svn_stringbuf_t *)' would that accept
>NULL as well?
>

It couldn't, could it. O.K., you've convinced me, so go ahead and commit
that patch. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org