Re: [PATCH] Re: Future-proofing "svn st" output

On Fri, Aug 30, 2002 at 11:23:02PM +0100, Gareth McCaughan wrote:
>...
> -------------------- patch begins --------------------

Note that your mailer wrapped the patch, which broke it. Please fix the
mailer :-), or attach it. If you attach, then please ensure it goes in as
text/plain (usually using a suffix of ".txt" for the patchfile will work)

Thanks for attaching the log; quite helpful.

>...
> +struct status_item {
> + const char *variants;
> + size_t width;
> + void (*fill_in)(char *, size_t, const svn_wc_status_t *);

You should be using apr_size_t throughout, rather than plain size_t.

>...
> +static size_t
> +traverse_fields (char *buffer,
> + char variant,
> + const svn_wc_status_t *status)
> +{
> + size_t offset = 0;
> + const status_item_t *item;
> +
> + for (item=all_fields; item->variants; ++item)

Some of the style is off. For example, we keep spaces around "=" and "+"
symbols.

>...
> +++ ./main.c Fri Aug 30 22:50:33 2002
> @@ -75,6 +75,7 @@
> {"strict", svn_cl__strict_opt, 0, "use strict semantics"},
> {"no-ignore", svn_cl__no_ignore_opt, 0,
> "disregard default and svn:ignore property
> ignores"},
> + {"describe-only", 'd', 0, "describe columns; don't really do
> status"},

This will be a *very* rarely used feature. We shouldn't burn the
single-letter option on it. Just --describe-only is sufficient.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org