Philip Martin <philip@codematters.co.uk> writes:
> Marcus Comstedt <marcus@mc.pp.se> writes:
>
> > What am I missing here?
>
> Someone to work out which APR functions we need to worry about.
> Someone to go through the Subversion code and make sure that we always
> convert "" to "/" before calling those APR functions. Feel free to
> send a patch :-) Just don't ask me to do it, I'm not interested. Like
> I said, I *am* making it easier for someone else to do it.
I have already sent in a patch that adds UTF-8 translations at those
places. So the places are easy to find, just M-x grep. Most of them
reside in libsvn_subr/io.c by the way. As I said earlier, I expect
the correct thing to do would be to make a call to a canonicalization
function wherever a path is converted _to_ UTF-8, and a call to a
decanonicalization function wherever a path is converted _from_
UTF-8. Then the appropriate handling of path separators and cwd names
can be put into these two functions as needed. The UTF-8 conversion
calls could also be moved into these two functions of course.
I'm not asking you to do it, I'm just discussing what a good design
should look like.
// Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 29 01:18:06 2002