Re: [RFC] Canonical Paths

Justin Erenkrantz <jerenkrantz@apache.org> writes:

> > 5. In some places the path library handles NULL paths. This is
> > unnecessary, as all inputs should be canonical, and so should be
> > removed (fixing any breakage that results).
>
> What is the interpretation of a NULL path?

Some functions (but not all) check for a NULL char * pointer, that's
not a canonical path. The inconsistency is not a good thing.

>
> > One question: svn_path_internal_style, which converts from native
> > separators to canonical separators, doesn't seem to be used. Should
> > the application pass all user input paths through this function?
>
> I think so. (should it also UTF-8 encode/decode it?) -- justin

UTF-8 already happens in svn_cl__args_to_target_array.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org