[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fixes svn's chdir before invoking $EDITOR for commit log message

From: Michael Wood <mwood_at_its.uct.ac.za>
Date: 2002-08-27 08:54:08 CEST

On Tue, Aug 27, 2002 at 01:03:11AM -0500, Karl Fogel wrote:
> If we really think this is a problem, we could write a function
> svn_path_dangerous_p() that simply returns true if a path is "funny"
> in the client environment (perhaps it should be apr_path_dangerous_p,
> but whatever). When any such path is involved in the commit, we'd
> refuse to pop up an editor, and insist that -F or -m be used instead.

If you're going to do this, rather have a "apr_path_safe_p" function.
It's much easier to test whether a path is safe than all the situations
in which it might be dangerous.

Michael Wood <mwood@its.uct.ac.za>
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 27 08:54:57 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.