[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3058 - trunk/subversion/libsvn_wc trunk/subversion/tests/clients/cmdline

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-08-25 17:53:59 CEST

philip@tigris.org wrote:
>
> Author: philip
> Date: 2002-08-25 09:59:44 -0500 (Sun, 25 Aug 2002)
> New Revision: 3058
>
> Modified:
> trunk/subversion/libsvn_wc/props.c
> trunk/subversion/tests/clients/cmdline/prop_tests.py
> Log:
> Don't allow inappropriate Subversion (svn:) properties to be set.
>
> * subversion/libsvn_wc/props.c
> (validate_prop_against_node_kind): New function.
> (svn_wc_prop_set): Don't allow inappropriate properties to be set, but
> allow such properties to be deleted. Only modify executable permission
> for files. Only clear text timestamp for files.
>
> * subversion/tests/clients/cmdline/prop_tests.py (inappropriate_props): New
> test.
>
> Modified: trunk/subversion/libsvn_wc/props.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/props.c (original)
> +++ trunk/subversion/libsvn_wc/props.c Sun Aug 25 09:59:50 2002
> @@ -1018,7 +1018,49 @@
> }
>
>
> +/* The special Subversion properties are not valid for all node kinds.
> + Return an error if NAME is an invalid Subversion property for PATH which
> + is of kind NODE_KIND. */
> +static svn_error_t *
> +validate_prop_against_node_kind (const char *name,
> + const char *path,
> + svn_node_kind_t node_kind,
> + apr_pool_t *pool)
> +{
> +
> + const char *file_prohibit[] = { SVN_PROP_IGNORE,
> + NULL };

How about adding svn:externals added to this list?

Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 25 17:54:31 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.