[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn -R ... how to get it really into svn

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-08-25 14:34:17 CEST

solo turn <soloturn99@yahoo.com> writes:

> some time ago i proposed a patch to make svn -R recurse over all
> directories, and does not stop if a directory already exists.
> there were 2 small comments on it (like use .. != .. instead of !(..
> == ..)
> but for a reason i still don't understand, the patch made it to the
> mailing list, noone objecting to it, but also noone seemed to care to
> really apply it to the source tree.
> what do i have to do to get a patch into the source tree?

Your original patch didn't have a log message. It helps to include one
for two reasons: first, it helps with the patch review, and second a
log message is required to commit, if you don't write it the person
committing it has to do it. Your patch broke the indentation of
surrounding code. As a reviewer pointed out, your patch didn't call
svn_error_clear_all when suppressing an error. Your patch didn't
include a regression test.

Now, none of the above means that your patch won't get applied. You
do not have to supply a complete patch/log/regression test, however
the more complete your patch, meaning less work for the person
applying it, the more likely it is that your patch will be committed.

I don't think your patch works with the current code, although I
haven't tried it so I may be wrong. I think this case will fail

$ svn mkdir foo
$ touch foo/zig.c
$ svn add -R foo

I think the solution is to modify the svn_wc_adm_open call in
svn_client_add, to set the TREE_LOCK argument to value of RECURSIVE.

Are you interested in updating your patch?

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 25 14:35:16 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.