Re: svn commit: rev 3023 - trunk/subversion/include

On Thu, Aug 22, 2002 at 03:20:49PM -0500, kfogel@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_error_codes.h Thu Aug 22 15:20:46 2002
> @@ -221,6 +221,10 @@
> SVN_ERR_ENTRY_CATEGORY_START + 0,
> "Can't find an entry")
>
> + SVN_ERRDEF (SVN_ERR_ENTRY_UNUSED_1,
> + SVN_ERR_ENTRY_CATEGORY_START + 1,
> + "Unused error code -- feel free to redefine me")
> +

Eek! If we have a hole, then let's just leave a comment rather than actually
*defining* an error. For two reasons:

1) the above is hard to recognize as "unused" with a quick visual scan
2) the above form defines a string constant, increasing the size of the app
   [a nit, but avoiding "bloat" is always nice]

I would recommend something simple like:

    /* UNUSED: + 1 */

APR uses lines like:

/* empty slot: +3 */

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org