Re: svn commit: rev 3014 - trunk/subversion/libsvn_subr

Branko ÄŒibej <brane@xbc.nu> writes:

> >>>>+ apr_err = apr_file_close (format_file);
> >>>>+ if (apr_err)
> >>>>+ return svn_error_createf (apr_err, 0, 0, pool,
> >>>>+ "closing `%s'", format_file);
> >>>>
>
> >>>../svn/subversion/libsvn_subr/io.c: In function `svn_io_read_version_file':
> >>>../svn/subversion/libsvn_subr/io.c:1901: warning: char format, apr_file_t arg (arg 6)
> >>>
>
> >>Bizarre -- why didn't I get that error??
> >>
>
> >
> >You are not using gcc 3.1.1 :)
> >
> Huh? -Wformat has been in gcc since forever.

Interesting. I just tried gcc versions 3.3, 3.1.1, 3.0.4 and 2.95.4.
Both 3.3 and 3.1.1 produce the warning (using -Wall), both 3.0.4 and
2.95.4 are silent (even with -Wformat). So, like Subversion, gcc is
getting better!

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org