[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3013 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby

From: <kevin_at_pilch-bisson.net>
Date: 2002-08-22 20:55:39 CEST

Quoting cmpilato@collab.net:

> kevin@pilch-bisson.net writes:
>
> > Quoting kfogel@tigris.org:
> >
> > > Author: kfogel
> > > Date: 2002-08-22 13:19:35 -0500 (Thu, 22 Aug 2002)
> > > New Revision: 3013
> > >
> > > Modified:
> > > trunk/subversion/bindings/ruby/wc.c
> > > trunk/subversion/include/svn_wc.h
> > > trunk/subversion/libsvn_wc/README
> > > trunk/subversion/libsvn_wc/adm_files.c
> > > trunk/subversion/libsvn_wc/entries.c
> > > trunk/subversion/libsvn_wc/log.c
> > > trunk/subversion/libsvn_wc/questions.c
> > > trunk/subversion/libsvn_wc/status.c
> > > trunk/subversion/libsvn_wc/update_editor.c
> > > trunk/subversion/libsvn_wc/wc.h
> > > Log:
> > > Fix issue #618. Thanks to Kevin Pilch-Bisson for providing the
> > > initial patch that became this change.
> > >
> >
> > Well thanks, but it wasn't me :)
>
> Whatchoo talkin' 'bout, Willis?!
>
> From: Kevin Pilch-Bisson <kevin@pilch-bisson.net>
> Subject: [PATCH] Fix issue 618.
> To: dev@subversion.tigris.org
> Date: Thu, 1 Aug 2002 01:09:35 -0400
> X-From-Line: dev-return-14136-cmpilato=collab.net@subversion.tigris.org
> Thu Aug 1 00:15:10 2002
> Return-Path: <dev-return-14136-cmpilato=collab.net@subversion.tigris.org>
> Received: from localhost (IDENT:cmpilato@localhost [127.0.0.1])
> by collab.net (8.9.3/8.8.7) with ESMTP id AAA20709
> for <cmpilato@localhost>; Thu, 1 Aug 2002 00:15:10 -0500
> Delivered-To: cmpilato@collab.net
> Received: from mail.collab.net
> by localhost with POP3 (fetchmail-5.3.1)
> for cmpilato@localhost (single-drop); Thu, 01 Aug 2002 00:15:10 -0500
> (CDT)
> Received: (qmail 609 invoked by uid 0); 1 Aug 2002 05:14:54 -0000
> Received: from two.tigris.org (HELO tigris.org) (64.125.132.254)
> by laswell.sfo.collab.net with SMTP; 1 Aug 2002 05:14:54 -0000
> Received: (qmail 31792 invoked by uid 5302); 1 Aug 2002 05:14:24 -0000
> Mailing-List: contact dev-help@subversion.tigris.org; run by ezmlm
> Precedence: bulk
> X-No-Archive: yes
> list-help: <mailto:dev-help@subversion.tigris.org>
> list-unsubscribe: <mailto:dev-unsubscribe@subversion.tigris.org>
> list-post: <mailto:dev@subversion.tigris.org>
> Delivered-To: mailing list dev@subversion.tigris.org
> Received: (qmail 31783 invoked from network); 1 Aug 2002 05:14:24 -0000
> Message-ID: <20020801050934.GA29701@pilch-bisson.net>
> Mail-Followup-To: dev@subversion.tigris.org
> Mime-Version: 1.0
> Content-Type: multipart/signed; micalg=pgp-sha1;
> protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI"
> Content-Disposition: inline
> User-Agent: Mutt/1.4i
> X-Spam-Status: No, hits=-5.0 required=7.0 tests=UNIFIED_PATCH version=2.20
> X-Spam-Level:
> X-UIDL: _$6!!?Xf!!>EW!!IdK!!
> Xref: pascal.ch.collab.net mail.software.subversion.patches:165
> Lines: 128
>
> Here is a patch which solves issue #618. The reason it's not applied
> is that it will break any existing working copies.
>
> [...]
>
> And here is the patch:
>
> Fix issue #618.
>
> * subversion/libsvn_wc/wc.h(SVN_WC__PROP_EXT): New define.
>
> * subversion/libsvn_wc/adm_files.c (prop_path_internal): Pass
> SVN_WC__PROP_EXT for the extension to property files.
> (svn_wc__open_props): Same.
> (svn_wc__close_props): Same.
> (svn_wc__sync_props): Same.
>

Okay, but Karl's patch (which I've deleted) at the least does more than just
fix issue 618. My patch just added the extension. His changes how we check
for a working copy and handles format and stuff like that!

--
Kevin Pilch-Bisson
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 22 20:56:10 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.