[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: expected failures shouldn't raise alarms

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-22 18:48:42 CEST

Branko Čibej <brane@xbc.nu> writes:
> Let me try to recapitulate what you want:
> * Lose the summary section
> * List only unexpected results (FAIL and XPASS)
> Right?

Right. (I probably should have included a concise summary in my

> One more detail: Does an XPASS mean the tests should fail (i.e., exit
> with non-zero)?

Hmmm. I don't really understand the purpose of XPASS, perhaps you can

If the idea is this:

   A bug is present in Subversion, and we've written an XPASS test
   such that as long as the bug is *present*, the test returns
   success, but as soon as the bug is fixed, the test will "fail".

...then I'd say we should simply reverse the sense of the test's
return value and make it an XFAIL instead. But maybe XPASS is about
something else?

> I'll bow to the majority opinion (strange, you seem to be a one-man
> majority :-), and fix things as soon as I get these answers. Then I'll
> add an XFAIL mechanism to the C tests, just to be consistent.

Thank you. (Maybe adjust subversion/tests/README while at it?)

I actually wasn't making the argument based on majority (perceived or
otherwise), but on the basis that we already made this decision and
never consensed on changing it. I'd be fine with people arguing
against my veto -- and would bow to majority opinion of developers,
since the whole point here is to be useful to people working on the
code. But based on the list discussion, it appears to be a simple
1-to-1 right now, between you and me, unless I missed a post.

However, SINCE you bring it up :-), I'll point out that Mike Pilato
concurred verbally with me, so if you want to count, it's really
2-to-1. I also feel pretty certain, based on many talks about the
test suite, that Ben Collins-Sussman would make that 3-1, but perhaps
I'm getting ahead of myself, and anyway, I don't want to set up a
Chicago mafia here... except when it serves my own nefarious purposes!


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 22 19:07:46 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.