Re: signal handling

On Tue, Aug 20, 2002 at 11:59:59AM -0700, Justin Erenkrantz wrote:
> On Tue, Aug 20, 2002 at 01:54:58PM -0500, cmpilato@collab.net wrote:
> > Communicate back to SVN? Huh? I don't know much about signal
> > handlers, but I assume that there is some signal handling function
> > that is registered as such in main(). That function would just run
> > svn_client_cleanup directly. Perhaps my ignorance is showing through
> > in a glaring way now, though...
>
> Greg's point is that you don't want to run svn_client_cleanup when
> you don't know where the program is. You'd only want to run
> svn_client_cleanup at specific places. That means, "set a global
> flag, various bits of SVN code, here, there everywhere periodically
> checks that flag" - which of course, is silly.
>
> I'd guess arbitrarily running svn_client_cleanup is much more
> dangerous than the current behavior. -- justin

also, it's not necessarily safe to do a lot of things (including using
malloc) inside a signal handler, so if svn_client_cleanup calls any
function that is async-signal unsafe (and deep down inside apr i imagine
it might), then we can't call it inside a signal handler anyway.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org