thats right.
an even more correct behaviour would be:
- to ignore all warnings in general.
imo a warning should not stop program
execution (otherwise it's an error).
- to throw away the "already exists error"
completely.
if somebody wants to add, and its there,
than its great, isn't it?
ignoring all warnings could go in the SVN_ERR(...) to be available
for everything.
SVN_ERR
if warning && verbose
print warningtext
if error
print errortext
return
is there a possibility to distinguish between warning and error?
--- Justin Erenkrantz <jerenkrantz@apache.org> wrote:
> On Sun, Aug 18, 2002 at 12:01:54PM -0700, solo turn wrote:
> > currently svn add -R stops on the first directory which exists,
> and
> > you have to fiddle out all the files you added by your own. this
> > patch allows to run svn -R in the wc-root, and add all new files.
> >
> > Index: ./subversion/libsvn_client/add.c
> >
> ===================================================================
> > --- ./subversion/libsvn_client/add.c
> > +++ ./subversion/libsvn_client/add.c 2002-08-18
> 20:40:44.593890000
> > +0200
> > @@ -51,10 +51,19 @@
> > svn_wc_adm_access_t *dir_access;
> >
> > /* Add this directory to revision control. */
> > - SVN_ERR (svn_wc_add (dirname, adm_access,
> > + err = svn_wc_add (dirname, adm_access,
> > NULL, SVN_INVALID_REVNUM,
> > - notify_added, notify_baton, pool));
> > + notify_added, notify_baton, pool);
> >
> > + if (err) {
> > + if (!(err->apr_err == SVN_ERR_ENTRY_EXISTS)) {
>
> Umm, why not:
>
> if (err->apr_err != SVN_ERR_ENTRY_EXISTS) {
>
> -- justin
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
__________________________________________________
Do You Yahoo!?
HotJobs - Search Thousands of New Jobs
http://www.hotjobs.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 19 16:40:19 2002