[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit invokes $EDITOR not where svn run from

From: Alexis Huxley <ahuxley_at_gmx.net>
Date: 2002-08-15 20:42:09 CEST

> > > If P is also an svn working copy directory, then we can use P's
> > > temp area. In other words, the target paths should always be
> > > constructed relative to the directory the editor is running in, and
> > > that directory should be the one from which the editor was invoked
> > > when possible (i.e., when it's an svn-controlled directory), else
> > > the lowest common root of all the targets when P is not an
> > > svn-controlled directory.
> >
> > That sounds reasonable. I suppose we could also try the current
> > directory, and only fall back on the working copy temp. area if the
> > current directory is not writeable.
>
> Even better, yeah!

Ok, I have something coded. I ran the commit_tests.py, but I
suspect that it doesn't invoke $EDITOR at all. ('grep -i editor'
doesn't find anything).

I'd like to submit a test with it if possible. But since this
change is specifically to do with the invocation of an interactive
program, I was thinking of setting:

        EDITOR="cat >"

in order to be able to pipe the log message 'through' svn. Or
even to write a little script:

        #!/bin/sh
        cat > $1
        echo "cwd=`pwd`, dircmpt=`dirname $1`" >&2

in order to get $EDITOR's opinion of cwd, and check that the tmp
file was relative to cwd.

So my question is: should I start learning Python so I can code
this, or is it sufficiently un-cross-platformy or integratable
to warrant not bothering? :-)

Alexis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 15 20:43:00 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.