Re: svn commit: rev 2949 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client trunk/subversion/clients/cmdline

"Sander Striker" <striker@apache.org> writes:
> This patch should do the trick.
>
> We can probably safely set STRICT to FALSE in svn_client_status,
> since STRICT didn't do anything before the changes.

?

It was not entirely without effect before rev 2949, I think. The code
in assemble_status() used to look like this:

      /* If we're in strict mode and we encounter a path that doesn't
         exist in the wc, then we return an error*/
      if (strict && (path_kind == svn_node_none))
        return svn_error_createf (APR_ENOENT, 0, NULL, pool,
                                  "assemble_status: "
                                  "%s: No such file or directory",
                                  path);

Do we know that this was an impossible condition, and that therefore
the `strict' flag was actually useless? (I realize this question is
more about rev 2949 than about the follow-up patch you just posted.)

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 13 17:48:57 2002