[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2945 - trunk/subversion/libsvn_wc

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-08-12 18:27:34 CEST

rooneg@tigris.org writes:
> * subversion/libsvn_wc/adm_files.c
> (check_adm_exists): when making sure the .svn/README file exists, use
> svn_io_check_path and check for svn_node_file instead of using svn_io_stat.
> this will catch the case where .svn/README is a directory. this also
> removes the check for APR_STATUS_IS_EEXISTS, since as far as i can tell
> EEXISTS isn't the kind of error we should be looking for anyway. in the
> case where the .svn/README file doesn't exist, we would be getting back
> APR_ENOENT from apr_stat anyway, and svn_io_check_path that for us.

Wow, I'm really batting a thousand today, ain't I? :-)

I wrote:
> Sorry, I thought the proposal was to change this to an
> svn_io_check_path(), and then test that kind == svn_node_dir. That
> boils down to a stat under the hood anyway, but is more stylistically
> consistent with the rest of Subversion, and (very slightly) safer too.

Glad this got changed,

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 12 18:44:08 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.