Re: [PATCH] fix svnadmin test on case insensitive filesystems

On Monday, August 12, 2002, at 11:52 AM, Karl Fogel wrote:

> William Uther <will+@cs.cmu.edu> writes:
>> Looks like there are two bugs in the test system. One that someone
>> else mentioned recently (I think), but which I can't find in the
>> archives: namely a test can fail and still "PASS".
>
> Can you describe this in more detail?
>
> We've had problems like this before. Thought we'd fixed them, but
> sounds like there is still at least one left...

The problem was pretty simple. The svnadmin test in question calls
run_svn() and doesn't check for errors in the return value because it is
just setting up for the "real" test. See my patch which makes both
run_svn() and run_svnadmin() throw exceptions when they are expecting to
work and fail
(http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=19852).

Note that that patch in turn reveals another problem that was being
hidden. Hence the patch in
(http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=19853).

later,

\x/ill :-}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 12 18:22:32 2002