[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Best Practices

From: Scott Lamb <slamb_at_slamb.org>
Date: 2002-08-08 20:11:13 CEST

Karl Fogel wrote:
> Scott Lamb <slamb@slamb.org> writes:
>>+@c ------------------------------------------------------
>>+@node When you commit
>>+@section When you commit
>>+It pays to take some time before you commit to review your changes and
>>+create an appropriate log message. Subversion does not have any convenient
>>+way of removing revisions (there is no equivalent to @samp{cvs admin -o}),
>>+so get it right the first time.
> The inability to remove committed revisions is unrelated to the
> quality of the log message. If the log message is bad, Subversion
> *does* offer the ability to fix it up afterwards -- so "get it right
> the first time" is not at all necessary here. And while revisions
> can't be removed, more tweaks can always be committed later... So even
> regarding the content of the change, the "get it right the first time"
> advice is a little unconvincing, at least when justified on that
> basis.

I once made the mistake of adding an OpenLDAP configuration file with my
root DN's password embedded. (Hashed in SSHA, but still.) So tweaking
later isn't always enough - you might want the incorrect stuff to not be
in the history at all. Since there's no way to remove a revision (short
of dumping/loading, and then probably manually re-adding any following
revisions), best to avoid that.

I was trying to say the changes can't be modified, not the log message.
I'll clarify. And add your other reason.

Scott Lamb
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 8 20:11:50 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.