Re: svn commit invokes $EDITOR not where svn run from

Marcus Comstedt <marcus@mc.pp.se> writes:

> cmpilato@collab.net writes:
>
> > Windows has environmental variables for answering this question. I
> > think the ordering is WINTMP, TMP, TEMP, but I can't recall with
> > certainty.
>
> And you can use them in what you pass to system(), having them
> automagically expanded somewhere along the way. Ok, then no problem
> there, except possibly an API one. If APR should generate the path to
> a tempdir, can it return a path which contains environment variable
> references? Even if it works with system(), will it work with other
> things you might want to do with a tempdir path?

Having said it might be easy, now I'm not so sure. Suppose I try

$ mkdir /tmp/\;rm\ -rf\ /
$ TMPDIR="/tmp/;rm -rf /" svn ci

I don't want that passed straight to system. APR would need to sanity
check the value which could be hard and is platform dependent. I
suppose APR could impose a limited set of acceptable characters.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org