[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit invokes $EDITOR not where svn run from

From: Alexis Huxley <ahuxley_at_gmx.net>
Date: 2002-08-08 17:07:44 CEST

Karl wrote:

> Yeah -- that seems very reasonable. Want to write the patch?
> Shouldn't be too complex (therefore the review and apply cycle will
> probably also be quick).

In light of other people's nagative comments I wasn't sure if
you're joking, but I'll do it if it's simple :-)

Philip wrote:

> No, it was a deliberate decision to cd. The temporary file is created
> in the temp. area of the path to be committed. By cd'ing we don't
> need to put the path into a system() call, which means that the shell
> cannot interpret characters in the path as "special".

I thought system() was bad anyway?

What's wrong with a normal fork() + exec()? The child does a chdir()
and uses probably execvp() on a sprintf() of getenv("EDITOR") and the
name of the temp file? Ok, I'm sure SVN has it's own way of calling
these functions, but ... did I miss something?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 8 17:08:19 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.