Re: paths, locks and canonicalisation

Philip Martin wrote:

>Hello
>
>Further path canonicalisation questions arise while messing around
>with the new locking code.
>
>Within libsvn_wc
>
>1. Is "." a canonical path?
>2. Is "A" a canonical path?
>

Yes, and yes. See the examples in the docstring for svn_path_split, in
svn_path.h. svn_path_split should do something smart with ".". Also,
maybe "./foo" should be canonicalized to "foo", and "" to "."?

>3. Should svn_path_is_child(".", "A") return NULL indicating not a
> child?
>
That's a tough question. I'd say that any relative path is a child of
the current dir, so svn_path_is_child should just return the second path
in this case.

I'm not sure we're consistent about "." and "./" prefixes, WRT
canonicalization, splitting and joining, but this is a perfect
opporunity to define a policy. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org